[FIXED] /banall shouln't work on 0.0.0.0 and 255.255.255.255

[BobKare]

I were banning one person for some reason named akking, surely NOT sharing ANYONE's IP!

fCraft version: 0.604_r1155
Number of players banned in total: 39

MARK: No one of the banned players are seen before, but in the database cause of a typo when promoting!

Here are pics:



Thanks looking into it,

-BobKare

[Sanjar Khan]

I am certain I'm not the only one who doesn't understand what it is you are trying to point out

[BobKare]

I did ban akking. you see the player akking in the first and the second picture? you do?
Good!

Now you see on akking's /Info that he doesn't share any other players IP!

All the other players getting banned in association with akking is "never seen before"!

Which means all players "Never seen before" in the PlayerDB does probably share the same "IP"!

You understand?

[Sanjar Khan]

You don't have to be so condescending, your english is just a complete mess.
Plus you didn't even mention this the first time round;

All the other players getting banned in association with akking is "never seen before"!

[BobKare]

MARK: No one of the banned players are seen before, but in the database cause of a typo when promoting!

[Sanjar Khan]

Yeah that's not a sentence

[DreamingInsane]

MARK: No one of the banned players are seen before, but in the database cause of a typo when promoting!

So they're in the database cuz some idiot promoted that name to a rank.

I can't really see how the issue went there though. Since the players don't really have an IP assigned until they actually login.

[Sanjar Khan]

How do you fuck up the promotion of 39 different players?

[DreamingInsane]

How do you fuck up the promotion of 39 different players?

No clue...

[Sanjar Khan]

I tried this and the samething happened, but I also noticed upon promoting nonexistent players that you have to verify your action with /ok.

[fragmer]

I'll look into it. It's possible that all those 39 players had "IPAddress.None" (i.e. "0.0.0.0"). In that case, /banall should've ignored them.

[BobKare]

well, finally one does understand me.

I think that should be the problem, yes, fragmer.

[fragmer]

Yep, looks like that was the problem. I'll fix this in the next patch.