[FIXED] /setinfo not being safe for console

Fixed bugs, solved problems, and old reports.
Locked
Jonty800
Offline
Posts: 280
Joined: August 21st, 2011, 6:31 am
Location: United Kingdom
Contact:

[FIXED] /setinfo not being safe for console

Post by Jonty800 »

used /setinfo displayedname on the console and it totally froze the serverGUI.
had to close it down with taskmanager
You cannot use certain BBCodes: [img].

User avatar
fragmer
fCraft Developer
Offline
Posts: 1386
Joined: May 21st, 2011, 10:53 pm

Re: /setinfo not being safe for console

Post by fragmer »

/SetInfo appears to be working properly from console for me. Can you give a specific example, or an excerpt from your logs?

Jonty800
Offline
Posts: 280
Joined: August 21st, 2011, 6:31 am
Location: United Kingdom
Contact:

Re: /setinfo not being safe for console

Post by Jonty800 »

there was no error, it just totally froze.

Possibly a random thing then I guess.
You cannot use certain BBCodes: [img].

User avatar
fragmer
fCraft Developer
Offline
Posts: 1386
Joined: May 21st, 2011, 10:53 pm

Re: /setinfo not being safe for console

Post by fragmer »

What exactly did you type in to make it freeze? Also, were you using ServerCLI or ServerGUI?

Jonty800
Offline
Posts: 280
Joined: August 21st, 2011, 6:31 am
Location: United Kingdom
Contact:

Re: /setinfo not being safe for console

Post by Jonty800 »

using the serverGUI

had the same problem a few moments a go with /kick, when using 3 strings.
typed in /setinfo rebelliousdude displayedname %ARebellious%fDude

and /kick rebelliousdude reason blah blah

it may just be my problem, since SVN update on tortoiseSVN messes up the source quite a lot.
You cannot use certain BBCodes: [img].

User avatar
fragmer
fCraft Developer
Offline
Posts: 1386
Joined: May 21st, 2011, 10:53 pm

Re: /setinfo not being safe for console

Post by fragmer »

Well, tortoiseSVN expects you to resolve code conflicts manually ;)

Jonty800
Offline
Posts: 280
Joined: August 21st, 2011, 6:31 am
Location: United Kingdom
Contact:

Re: /setinfo not being safe for console

Post by Jonty800 »

I always do, but when I use SVNupdate for a few weeks it starts missing out sections of code. For example, the last time I updated, it didnt change any of the BlockUpdate code in the whole of ZoneCommands or add /triangle

:(
You cannot use certain BBCodes: [img].

User avatar
Lim-Dul
The Necromancer
Offline
Posts: 663
Joined: May 21st, 2011, 10:21 pm

Re: /setinfo not being safe for console

Post by Lim-Dul »

Do a fresh checkout. :3
War does not determine who is right - only who is left. - Bertrand Russell

User avatar
boblol0909
SupOP
Offline
Posts: 314
Joined: June 24th, 2011, 10:27 pm

Re: /setinfo not being safe for console

Post by boblol0909 »

RapidSVN ftw

Jonty800
Offline
Posts: 280
Joined: August 21st, 2011, 6:31 am
Location: United Kingdom
Contact:

Re: /setinfo not being safe for console

Post by Jonty800 »

yeah I do a fresh checkout every now and then, its such a hassle to move so much code over though.

never heard of RapidSVN, good I guess?
You cannot use certain BBCodes: [img].

User avatar
Lim-Dul
The Necromancer
Offline
Posts: 663
Joined: May 21st, 2011, 10:21 pm

Re: /setinfo not being safe for console

Post by Lim-Dul »

Jonty800 wrote:yeah I do a fresh checkout every now and then, its such a hassle to move so much code over though.

never heard of RapidSVN, good I guess?
No support for modded versions of fCraft. *whistles*
War does not determine who is right - only who is left. - Bertrand Russell

Jonty800
Offline
Posts: 280
Joined: August 21st, 2011, 6:31 am
Location: United Kingdom
Contact:

Re: /setinfo not being safe for console

Post by Jonty800 »

to be fair, I did think this was an fCraft bug :P
You cannot use certain BBCodes: [img].

User avatar
fragmer
fCraft Developer
Offline
Posts: 1386
Joined: May 21st, 2011, 10:53 pm

Re: /setinfo not being safe for console

Post by fragmer »

Check r1208. I fixed a bug there that used to potentially cause hanging. Fix is to change .Invoke(...) calls to .BeginInvoke(...) calls in ServerGUI's MainForm class. Specifically, in the following methods:
  • OnLogged
  • OnHeartbeatUriChanged
  • OnPlayerListChanged
  • OnServerShutdownEnded

Jonty800
Offline
Posts: 280
Joined: August 21st, 2011, 6:31 am
Location: United Kingdom
Contact:

Re: /setinfo not being safe for console

Post by Jonty800 »

yeah we're using r1156 so that seems to be the problem.

Thanks fragmer!
You cannot use certain BBCodes: [img].

Locked