[FIXED] Banned player remains online
[FIXED] Banned player remains online
Apparently after a /banall, this guy remained on the server even though he was banned. He had the red asterisk as well. Not sure if its a bug or just a random glitch.
<+FCB1> 05+Pemalite: all the fcraft chicks reject me except element
13:04 + FCB2 │ +Pemalite: craaaaab
13:04 + FCB1 │ +Pemalite: no
13:04 + FCB1 │ +Pemalite: ill give yout the best loving ou ever ad crab
13:04 + FCB2 │ +Pemalite: craaaaab
13:04 + FCB1 │ +Pemalite: no
13:04 + FCB1 │ +Pemalite: ill give yout the best loving ou ever ad crab
Re: Banned player remains online
I'll check the logs.
EDIT:
Looks like Hicks31 was fully connected and loading the main map while he was being banned. That's a fairly rare coincidence.
EDIT:
Code: Select all
00:54:21 > Player Hicks31 connected from 66.10.94.35.
00:54:21 > Player Hicks31 joined world main.
00:54:21 > Player.JoinWorldNow: Sending compressed map (261277 bytes) to Hicks31.
00:54:23 > KingCrab72: /banall guthix1234 Griefing IP
00:54:23 > IPBanList.Save: Saving IP ban list (4196 records).
00:54:23 > KingCrab72 banned 66.10.94.35 (BanAll guthix1234). Reason: Griefing IP
00:54:23 > KingCrab72 banned bigkeat31 (BanAll guthix1234). Reason: Griefing IP
00:54:23 > KingCrab72 banned guthix1234 (BanAll guthix1234). Reason: Griefing IP
00:54:23 > KingCrab72 banned Hicks31 (BanAll guthix1234). Reason: Griefing IP
00:54:23 > guthix1234 left the server (BanAll).
00:54:29 > Player Hicks31* logged in from an IP shared by banned players: bigkeat31, guthix1234, Hicks31
Re: Banned player remains online
I have experienced this issue numerous times in the same situation. Just kicking them is the only alternative, they won't be able to log in afterwards, normally.
Re: Banned player remains online
Same. This has happened to me several times. It's not often, but it should be something fragmer should look into.AliceRed wrote:I have experienced this issue numerous times in the same situation. Just kicking them is the only alternative, they won't be able to log in afterwards, normally.
- Intertoothh
- Trustee
- Offline
- Posts: 1149
- Joined: May 24th, 2011, 5:51 am
Re: Banned player remains online
He did.BobKare wrote: It's not often, but it should be something fragmer should look into.
And a simple kick will solve this.Fragmer wrote:Looks like Hicks31 was fully connected and loading the main map while he was being banned. That's a fairly rare coincidence.
McLaughlinKid wrote:You put roar on everything don't you?
Re: Banned player remains online
<technical details> I check whether the player is banned before "accepting" them into the server. There is a window of several milliseconds between the ban check and the acceptance in which the ban has to take place. Basically, a threading race condition. I'll see if I can move the ban-checking code into the thread-synchronized part of the code that deals with acceptance.
TLDR: I'll fix it.
TLDR: I'll fix it.