Page 1 of 1
[FIXED] /banall shouln't work on 0.0.0.0 and 255.255.255.255
Posted: October 30th, 2011, 12:08 pm
by BobKare
I were banning one person for some reason named akking, surely NOT sharing ANYONE's IP!
fCraft version: 0.604_r1155
Number of players banned in total: 39
MARK: No one of the banned players are seen before, but in the database cause of a typo when promoting!
Here are pics:
Thanks looking into it,
-BobKare
Re: /banall bug. lol...
Posted: October 30th, 2011, 2:12 pm
by Sanjar Khan
I am certain I'm not the only one who doesn't understand what it is you are trying to point out
Re: /banall bug. lol...
Posted: October 30th, 2011, 2:22 pm
by BobKare
I did ban akking. you see the player akking in the first and the second picture? you do?
Good!
Now you see on akking's /Info that he doesn't share any other players IP!
All the other players getting banned in association with akking is "never seen before"!
Which means all players "Never seen before" in the PlayerDB does probably share the same "IP"!
You understand?
Re: /banall bug. lol...
Posted: October 30th, 2011, 2:44 pm
by Sanjar Khan
You don't have to be so condescending, your english is just a complete mess.
Plus you didn't even mention this the first time round;
All the other players getting banned in association with akking is "never seen before"!
Re: /banall bug. lol...
Posted: October 30th, 2011, 2:54 pm
by BobKare
BobKare wrote:MARK: No one of the banned players are seen before, but in the database cause of a typo when promoting!
Re: /banall bug. lol...
Posted: October 30th, 2011, 3:00 pm
by Sanjar Khan
Yeah that's not a sentence
Re: /banall bug. lol...
Posted: October 30th, 2011, 4:18 pm
by DreamingInsane
BobKare wrote:BobKare wrote:MARK: No one of the banned players are seen before, but in the database cause of a typo when promoting!
So they're in the database cuz some idiot promoted that name to a rank.
I can't really see how the issue went there though. Since the players don't really have an IP assigned until they actually login.
Re: /banall bug. lol...
Posted: October 30th, 2011, 4:21 pm
by Sanjar Khan
How do you fuck up the promotion of 39 different players?
Re: /banall bug. lol...
Posted: October 30th, 2011, 4:35 pm
by DreamingInsane
Sanjar Khan wrote:How do you fuck up the promotion of 39 different players?
No clue...
Re: /banall bug. lol...
Posted: October 30th, 2011, 4:40 pm
by Sanjar Khan
I tried this and the samething happened, but I also noticed upon promoting nonexistent players that you have to verify your action with /ok.
Re: /banall bug. lol...
Posted: October 30th, 2011, 6:56 pm
by fragmer
I'll look into it. It's possible that all those 39 players had "IPAddress.None" (i.e. "0.0.0.0"). In that case, /banall should've ignored them.
Re: /banall bug. lol...
Posted: October 30th, 2011, 8:57 pm
by BobKare
well, finally one does understand me.
I think that should be the problem, yes, fragmer.
Re: /banall bug. lol...
Posted: October 30th, 2011, 9:47 pm
by fragmer
Yep, looks like that was the problem. I'll fix this in the next patch.