Page 1 of 1
[FIXED] /setinfo not being safe for console
Posted: November 10th, 2011, 3:44 am
by Jonty800
used /setinfo displayedname on the console and it totally froze the serverGUI.
had to close it down with taskmanager
Re: /setinfo not being safe for console
Posted: November 10th, 2011, 5:09 am
by fragmer
/SetInfo appears to be working properly from console for me. Can you give a specific example, or an excerpt from your logs?
Re: /setinfo not being safe for console
Posted: November 10th, 2011, 10:15 pm
by Jonty800
there was no error, it just totally froze.
Possibly a random thing then I guess.
Re: /setinfo not being safe for console
Posted: November 10th, 2011, 10:39 pm
by fragmer
What exactly did you type in to make it freeze? Also, were you using ServerCLI or ServerGUI?
Re: /setinfo not being safe for console
Posted: November 11th, 2011, 1:05 am
by Jonty800
using the serverGUI
had the same problem a few moments a go with /kick, when using 3 strings.
typed in /setinfo rebelliousdude displayedname %ARebellious%fDude
and /kick rebelliousdude reason blah blah
it may just be my problem, since SVN update on tortoiseSVN messes up the source quite a lot.
Re: /setinfo not being safe for console
Posted: November 11th, 2011, 1:31 am
by fragmer
Well, tortoiseSVN expects you to resolve code conflicts manually

Re: /setinfo not being safe for console
Posted: November 11th, 2011, 2:54 am
by Jonty800
I always do, but when I use SVNupdate for a few weeks it starts missing out sections of code. For example, the last time I updated, it didnt change any of the BlockUpdate code in the whole of ZoneCommands or add /triangle

Re: /setinfo not being safe for console
Posted: November 11th, 2011, 3:11 am
by Lim-Dul
Do a fresh checkout. :3
Re: /setinfo not being safe for console
Posted: November 11th, 2011, 3:59 am
by boblol0909
RapidSVN ftw
Re: /setinfo not being safe for console
Posted: November 11th, 2011, 4:25 am
by Jonty800
yeah I do a fresh checkout every now and then, its such a hassle to move so much code over though.
never heard of RapidSVN, good I guess?
Re: /setinfo not being safe for console
Posted: November 11th, 2011, 6:32 am
by Lim-Dul
Jonty800 wrote:yeah I do a fresh checkout every now and then, its such a hassle to move so much code over though.
never heard of RapidSVN, good I guess?
No support for modded versions of fCraft. *whistles*
Re: /setinfo not being safe for console
Posted: November 11th, 2011, 4:22 pm
by Jonty800
to be fair, I did think this was an fCraft bug

Re: /setinfo not being safe for console
Posted: November 12th, 2011, 3:07 am
by fragmer
Check r1208. I fixed a bug there that used to potentially cause hanging. Fix is to change .Invoke(...) calls to .BeginInvoke(...) calls in ServerGUI's MainForm class. Specifically, in the following methods:
- OnLogged
- OnHeartbeatUriChanged
- OnPlayerListChanged
- OnServerShutdownEnded
Re: /setinfo not being safe for console
Posted: November 12th, 2011, 3:27 pm
by Jonty800
yeah we're using r1156 so that seems to be the problem.
Thanks fragmer!